Advanced search development guidelines
This page includes information about developing and working with Advanced search, which is powered by Elasticsearch.
Information on how to enable Advanced search and perform the initial indexing is in the Elasticsearch integration documentation.
Deep dive resources
These recordings and presentations provide in-depth knowledge about the Advanced search implementation:
Date | Topic | Presenter | Resources | GitLab Version |
---|---|---|---|---|
July 2024 | Advanced search basics, integration, indexing, and search | Terri Chu |
Recording on YouTube (GitLab team members only) Google slides (GitLab team members only) |
GitLab 17.0 |
June 2021 | GitLabs data migration process for Advanced search | Dmitry Gruzd | Blog post | GitLab 13.12 |
August 2020 | GitLab-specific architecture for multi-indices support | Mark Chao |
Recording on YouTube Google slides |
GitLab 13.3 |
June 2019 | GitLab Elasticsearch integration | Mario de la Ossa |
Recording on YouTube Google slides |
GitLab 12.0 |
Elasticsearch configuration
Supported versions
See Version Requirements.
Developers making significant changes to Elasticsearch queries should test their features against all our supported versions.
Setting up your development environment
-
Ensure Elasticsearch is running:
curl "http://localhost:9200"
- Run Kibana to interact with your local Elasticsearch cluster. Alternatively, you can use Cerebro or a similar tool.
-
To tail the logs for Elasticsearch, run this command:
tail -f log/elasticsearch.log
Helpful Rake tasks
-
gitlab:elastic:test:index_size
: Tells you how much space the current index is using, as well as how many documents are in the index. -
gitlab:elastic:test:index_size_change
: Outputs index size, reindexes, and outputs index size again. Useful when testing improvements to indexing size.
Additionally, if you need large repositories or multiple forks for testing, consider following these instructions
Development workflow
Development tips
- Creating indices from scratch
- Index data
- Updating dependent associations in the index
- Kibana
- Running tests with Elasticsearch
- Testing migrations
- Viewing index status
Debugging & troubleshooting
Debugging Elasticsearch queries
The ELASTIC_CLIENT_DEBUG
environment variable enables
the debug option for the Elasticsearch client
in development or test environments. If you need to debug Elasticsearch HTTP queries generated from
code or tests, it can be enabled before running specs or starting the Rails console:
ELASTIC_CLIENT_DEBUG=1 bundle exec rspec ee/spec/workers/search/elastic/trigger_indexing_worker_spec.rb
export ELASTIC_CLIENT_DEBUG=1
rails console
flood stage disk watermark [95%] exceeded
Getting You might get an error such as
[2018-10-31T15:54:19,762][WARN ][o.e.c.r.a.DiskThresholdMonitor] [pval5Ct]
flood stage disk watermark [95%] exceeded on
[pval5Ct7SieH90t5MykM5w][pval5Ct][/usr/local/var/lib/elasticsearch/nodes/0] free: 56.2gb[3%],
all indices on this node will be marked read-only
This is because you've exceeded the disk space threshold - it thinks you don't have enough disk space left, based on the default 95% threshold.
In addition, the read_only_allow_delete
setting will be set to true
. It will block indexing, forcemerge
, etc
curl "http://localhost:9200/gitlab-development/_settings?pretty"
Add this to your elasticsearch.yml
file:
# turn off the disk allocator
cluster.routing.allocation.disk.threshold_enabled: false
or
# set your own limits
cluster.routing.allocation.disk.threshold_enabled: true
cluster.routing.allocation.disk.watermark.flood_stage: 5gb # ES 6.x only
cluster.routing.allocation.disk.watermark.low: 15gb
cluster.routing.allocation.disk.watermark.high: 10gb
Restart Elasticsearch, and the read_only_allow_delete
will clear on its own.
from "Disk-based Shard Allocation | Elasticsearch Reference" 5.6 and 6.x
Performance monitoring
Prometheus
GitLab exports Prometheus metrics relating to the number of requests and timing for all web/API requests and Sidekiq jobs, which can help diagnose performance trends and compare how Elasticsearch timing is impacting overall performance relative to the time spent doing other things.
Indexing queues
GitLab also exports Prometheus metrics for indexing queues, which can help diagnose performance bottlenecks and determine whether your GitLab instance or Elasticsearch server can keep up with the volume of updates.
Logs
All indexing happens in Sidekiq, so much of the relevant logs for the
Elasticsearch integration can be found in
sidekiq.log
. In particular, all
Sidekiq workers that make requests to Elasticsearch in any way will log the
number of requests and time taken querying/writing to Elasticsearch. This can
be useful to understand whether or not your cluster is keeping up with
indexing.
Searching Elasticsearch is done via ordinary web workers handling requests. Any
requests to load a page or make an API request, which then make requests to
Elasticsearch, will log the number of requests and the time taken to
production_json.log
. These
logs will also include the time spent on Database and Gitaly requests, which
may help to diagnose which part of the search is performing poorly.
There are additional logs specific to Elasticsearch that are sent to
elasticsearch.log
that may contain information to help diagnose performance issues.
Performance Bar
Elasticsearch requests will be displayed in the
Performance Bar
, which can
be used both locally in development and on any deployed GitLab instance to
diagnose poor search performance. This will show the exact queries being made,
which is useful to diagnose why a search might be slow.
X-Opaque-Id
Correlation ID and Our correlation ID
is forwarded by all requests from Rails to Elasticsearch as the
X-Opaque-Id
header which allows us to track any
tasks
in the cluster back the request in GitLab.
Architecture
The framework used to communicate to Elasticsearch is in the process of a refactor tracked in this epic.
Indexing Overview
Advanced search selectively indexes data. Each data type follows a specific indexing pipeline:
Data type | How is it queued | Where is it queued | Where does indexing occur |
---|---|---|---|
Database records | Record changes through ActiveRecord callbacks and Gitlab::EventStore
|
Redis ZSET |
ElasticIndexInitialBulkCronWorker , ElasticIndexBulkCronWorker
|
Git repository data | Branch push service and default branch change worker | Sidekiq |
Search::Elastic::CommitIndexerWorker , ElasticWikiIndexerWorker
|
Embeddings | Record changes through ActiveRecord callbacks and Gitlab::EventStore
|
Redis ZSET | ElasticEmbeddingBulkCronWorker |
Indexing Components
External Indexer
For repository content, GitLab uses a dedicated indexer written in Go to efficiently process files.
Rails Indexing Lifecycle
- Initial Indexing: Administrators trigger the first complete index via the Admin UI or a Rake task
-
Ongoing Updates: After initial setup, GitLab maintains index currency through:
- Model callbacks (
after_create
,after_update
,after_destroy
) defined in/ee/app/models/concerns/elastic/application_versioned_search.rb
- A Redis
ZSET
that tracks all pending changes - Scheduled Sidekiq workers that process these queues in batches using Elasticsearch's Bulk Request API
- Model callbacks (
Search and Security
The query builder framework generates search queries and handles access control logic. This portion of the codebase requires particular attention during development and code review, as it has historically been a source of security vulnerabilities.
The final step in returning search results is to redact unauthorized results for the current user to catch problems with the queries or race conditions.
Migration framework
GitLabs Advanced search includes a robust migration framework that streamlines index maintenance and updates. This system provides significant benefits:
- Selective Reindexing: Only updates specific document types when needed, avoiding full re-indexes
- Automated Maintenance: Updates proceed without requiring human intervention
- Consistent Experience: Provides the same migration path for both GitLab.com and self-managed instances
Framework Components
The migration system consists of:
- Migration Runner: A cron worker that executes every 5 minutes to check for and process pending migrations.
- Migration Files: Similar to database migrations, these Ruby files define the migration steps with accompanying YAML documentation
- Migration Status Tracking: All migration states are stored in a dedicated Elasticsearch index
- Migration Lifecycle States: Each migration progresses through stages: pending → in progress → complete (or halted if issues arise)
Configuration Options
Migrations can be fine-tuned with various parameters:
- Batching: Control the document batch size for optimal performance
- Throttling: Adjust indexing speed to balance between migration speed and system load
- Space Requirements: Verify sufficient disk space before migrations begin to prevent interruptions
- Skip condition: Define a condition for skipping the migration
This framework makes index schema changes, field updates, and data migrations reliable and unobtrusive for all GitLab installations.
Search DSL
This section covers the Search DSL (Domain Specific Language) supported by GitLab, which is compatible with both Elasticsearch and OpenSearch implementations.
Custom routing
Custom routing
is used in Elasticsearch for document types. The routing format is usually project_<project_id>
for project associated data
and group_<root_namespace_id>
for group associated data. Routing is set during indexing and searching operations and tells
Elasticsearch what shards to put the data into. Some of the benefits and tradeoffs to using custom routing are:
- Project and group scoped searches are much faster since not all shards have to be hit.
- Routing is not used if too many shards would be hit for global and group scoped searches.
- Shard size imbalance might occur.
Existing analyzers and tokenizers
The following analyzers and tokenizers are defined in
ee/lib/elastic/latest/config.rb
.
Analyzers
path_analyzer
Used when indexing blobs' paths. Uses the path_tokenizer
and the lowercase
and asciifolding
filters.
See the path_tokenizer
explanation below for an example.
sha_analyzer
Used in blobs and commits. Uses the sha_tokenizer
and the lowercase
and asciifolding
filters.
See the sha_tokenizer
explanation later below for an example.
code_analyzer
Used when indexing a blob's filename and content. Uses the whitespace
tokenizer
and the word_delimiter_graph
,
lowercase
, and asciifolding
filters.
The whitespace
tokenizer was selected to have more control over how tokens are split. For example the string Foo::bar(4)
needs to generate tokens like Foo
and bar(4)
to be properly searched.
See the code
filter for an explanation on how tokens are split.
Tokenizers
sha_tokenizer
This is a custom tokenizer that uses the
edgeNGram
tokenizer
to allow SHAs to be searchable by any sub-set of it (minimum of 5 chars).
Example:
240c29dc7e
becomes:
240c2
240c29
240c29d
240c29dc
240c29dc7
240c29dc7e
path_tokenizer
This is a custom tokenizer that uses the
path_hierarchy
tokenizer
with reverse: true
to allow searches to find paths no matter how much or how little of the path is given as input.
Example:
'/some/path/application.js'
becomes:
'/some/path/application.js'
'some/path/application.js'
'path/application.js'
'application.js'
Common gotchas
- Searches can have their own analyzers. Remember to check when editing analyzers.
-
Character
filters (as opposed to token filters) always replace the original character. These filters can hinder exact searches.
Implementation guide
Add a new document type to Elasticsearch
If data cannot be added to one of the existing indices in Elasticsearch, follow these instructions to set up a new index and populate it.
Recommended process for adding a new document type
Have any MRs reviewed by a member of the Global Search team:
- Setup your development environment
- Create the index.
- Validate expected queries
- Create a new Elasticsearch reference.
- Perform continuous updates behind a feature flag. Enable the flag fully before the backfill.
- Backfill the data.
After indexing is done, the index is ready for search.
Create the index
All new indexes must have:
-
project_id
andnamespace_id
fields (if available). One of the fields must be used for custom routing. - A
traversal_ids
field for efficient global and group search. Populate the field withobject.namespace.elastic_namespace_ancestry
- Fields for authorization:
- For project data -
visibility_level
- For group data -
namespace_visibility_level
- Any required access level fields. These correspond to project feature access levels such as
issues_access_level
orrepository_access_level
- For project data -
- A
schema_version
integer field in aYYWW
(year/week) format. This field is used for data migrations.
-
Create a
Search::Elastic::Types::
class inee/lib/search/elastic/types/
. -
Define the following class methods:
-
index_name
: in the formatgitlab-<env>-<type>
(for example,gitlab-production-work_items
). -
mappings
: a hash containing the index schema such as fields, data types, and analyzers. -
settings
: a hash containing the index settings such as replicas and tokenizers. The default is good enough for most cases.
-
-
Add a new advanced search migration to create the index by executing
scripts/elastic-migration
and following the instructions. The migration name must be in the formatCreate<Name>Index
. -
Use the
Search::Elastic::MigrationCreateIndexHelper
helper and the'migration creates a new index'
shared example for the specification file created. -
Add the target class to
Gitlab::Elastic::Helper::ES_SEPARATE_CLASSES
. -
To test the index creation, run
Elastic::MigrationWorker.new.perform
in a console and check that the index has been created with the correct mappings and settings:curl "http://localhost:9200/gitlab-development-<type>/_mappings" | jq .`
curl "http://localhost:9200/gitlab-development-<type>/_settings" | jq .`
PostgreSQL to Elasticsearch mappings
Data types for primary and foreign keys must match the column type in the database. For example, the database column
type integer
maps to integer
and bigint
maps to long
in the mapping.
Nested fields introduce significant overhead. A flattened multi-value approach is recommended instead.
PostgreSQL type | Elasticsearch mapping |
---|---|
bigint | long |
smallint | short |
integer | integer |
boolean | boolean |
array | keyword |
timestamp | date |
character varying, text | Depends on query requirements. Use text for full-text search and keyword for term queries, sorting, or aggregations |
Validate expected queries
Before creating a new index, it's crucial to validate that the planned mappings will support your expected queries. Verifying mapping compatibility upfront helps avoid issues that would require index rebuilding later.
Create a new Elastic Reference
Create a Search::Elastic::References::
class in ee/lib/search/elastic/references/
.
The reference is used to perform bulk operations in Elasticsearch.
The file must inherit from Search::Elastic::Reference
and define the following constant and methods:
include Search::Elastic::Concerns::DatabaseReference # if there is a corresponding database record for every document
SCHEMA_VERSION = 24_46 # integer in YYWW format
override :serialize
def self.serialize(record)
# a string representation of the reference
end
override :instantiate
def self.instantiate(string)
# deserialize the string and call initialize
end
override :preload_indexing_data
def self.preload_indexing_data(refs)
# remove this method if `Search::Elastic::Concerns::DatabaseReference` is included
# otherwise return refs
end
def initialize
# initialize with instance variables
end
override :identifier
def identifier
# a way to identify the reference
end
override :routing
def routing
# Optional: an identifier to route the document in Elasticsearch
end
override :operation
def operation
# one of `:index`, `:upsert` or `:delete`
end
override :serialize
def serialize
# a string representation of the reference
end
override :as_indexed_json
def as_indexed_json
# a hash containing the document represenation for this reference
end
override :index_name
def index_name
# index name
end
def model_klass
# set to the model class if `Search::Elastic::Concerns::DatabaseReference` is included
end
To add data to the index, an instance of the new reference class is called in
Elastic::ProcessBookkeepingService.track!()
to add the data to a queue of
references for indexing.
A cron worker pulls queued references and bulk-indexes the items into Elasticsearch.
To test that the indexing operation works, call Elastic::ProcessBookkeepingService.track!()
with an instance of the reference class and run Elastic::ProcessBookkeepingService.new.execute
.
The logs show the updates. To check the document in the index, run this command:
curl "http://localhost:9200/gitlab-development-<type>/_search"
Data consistency
Now that we have an index and a way to bulk index the new document type into Elasticsearch, we need to add data into the index. This consists of doing a backfill and doing continuous updates to ensure the index data is up to date.
The backfill is done by calling Elastic::ProcessInitialBookkeepingService.track!()
with an instance of Search::Elastic::Reference
for every document that should be indexed.
The continuous update is done by calling Elastic::ProcessBookkeepingService.track!()
with an instance of Search::Elastic::Reference
for every document that should be created/updated/deleted.
Backfilling data
Add a new Advanced Search migration to backfill data by executing scripts/elastic-migration
and following the instructions.
Use the MigrationDatabaseBackfillHelper
. The BackfillWorkItems
migration can be used as an example.
To test the backfill, run Elastic::MigrationWorker.new.perform
in a console a couple of times and see that the index was populated.
Tail the logs to see the progress of the migration:
tail -f log/elasticsearch.log
Continuous updates
For ActiveRecord
objects, the ApplicationVersionedSearch
concern can be included on the model to index data based on callbacks. If that's not suitable, call Elastic::ProcessBookkeepingService.track!()
with an instance of Search::Elastic::Reference
whenever a document should be indexed.
Always check for Gitlab::CurrentSettings.elasticsearch_indexing?
and use_elasticsearch?
because some GitLab Self-Managed instances do not have Elasticsearch enabled and namespace limiting can be enabled.
Also check that the index is able to handle the index request. For example, check that the index exists if it was added in the current major release by verifying that the migration to add the index was completed: Elastic::DataMigrationService.migration_has_finished?
.
Transfers and deletes
Project and group transfers and deletes must make updates to the index to avoid orphaned data. Orphaned data may occur
when custom routing changes due to a transfer. Data in the old shard must be cleaned up. Elasticsearch
updates for transfers are handled in the Projects::TransferService
and Groups::TransferService
.
Indexes that contain a project_id
field must use the Search::Elastic::DeleteWorker
.
Indexes that contain a namespace_id
field and no project_id
field must use Search::ElasticGroupAssociationDeleteWorker
.
- Add the indexed class to
excluded_classes
inElasticDeleteProjectWorker
- Update the worker to remove documents from the index
Implementing search for a new document type
Search data is available in SearchController
and
Search API. Both use the SearchService
to return results.
The SearchService
can be used to return results outside the SearchController
and Search API
.
Recommended process for implementing search for a new document type
Create the following MRs and have them reviewed by a member of the Global Search team:
- Enable the new scope.
- Create a query builder.
- Implement all model requirements.
-
Add the new scope to
Gitlab::Elastic::SearchResults
behind a feature flag. - Add support for the scope in
Search::API
(if applicable) - Add specs which must include permissions tests
- Test the new scope
- Update documentation for Advanced search, Search API and, Roles and permissions (if applicable)
Search scopes
The SearchService
exposes searching at global,
group, and project levels.
New scopes must be added to the following constants:
-
ALLOWED_SCOPES
(or overrideallowed_scopes
method) in each EESearchService
file -
ALLOWED_SCOPES
inGitlab::Search::AbuseDetection
-
search_tab_ability_map
method inSearch::Navigation
. Override in the EE version if needed
Global search can be disabled for a scope. You can do the following changes for disabling global search:
- Add an application setting named
global_search_SCOPE_enabled
that defaults totrue
under thesearch
jsonb accessor inapp/models/application_setting.rb
. - Add an entry in JSON schema validator file
application_setting_search.json
- Add the setting checkbox in the Admin UI by creating an entry in
global_search_settings_checkboxes
method inApplicationSettingsHelper
. - Add it to the
global_search_enabled_for_scope?
method inSearchService
. - Remember that EE-only settings should be added in the EE versions of the files
Results classes
The search results class available are:
Search type | Search level | Class |
---|---|---|
Basic search | global | Gitlab::SearchResults |
Basic search | group | Gitlab::GroupSearchResults |
Basic search | project | Gitlab::ProjectSearchResults |
Advanced search | global | Gitlab::Elastic::SearchResults |
Advanced search | group | Gitlab::Elastic::GroupSearchResults |
Advanced search | project | Gitlab::Elastic::ProjectSearchResults |
Exact code search | global | Search::Zoekt::SearchResults |
Exact code search | group | Search::Zoekt::SearchResults |
Exact code search | project | Search::Zoekt::SearchResults |
All search types | All levels | Search::EmptySearchResults |
The result class returns the following data:
-
objects
- paginated from Elasticsearch transformed into database records or POROs -
formatted_count
- document count returned from Elasticsearch -
highlight_map
- map of highlighted fields from Elasticsearch -
failed?
- if a failure occurred -
error
- error message returned from Elasticsearch -
aggregations
- (optional) aggregations from Elasticsearch
New scopes must add support to these methods within Gitlab::Elastic::SearchResults
class:
objects
formatted_count
highlight_map
failed?
error
Updating an existing scope
Updates may include adding and removing document fields or changes to authorization. To update an existing scope, find the code used to generate queries and JSON for indexing.
- Queries are generated in
QueryBuilder
classes - Indexed documents are built in
Reference
classes
We also support a legacy Proxy
framework:
- Queries are generated in
ClassProxy
classes - Indexed documents are built in
InstanceProxy
classes
Always aim to create new search filters in the QueryBuilder
framework, even if they are used in the legacy framework.
Adding a field
Add the field to the index
- Add the field to the index mapping to add it newly created indices
- Create a migration to add the field to existing indices. Use the
MigrationUpdateMappingsHelper
- Populate the new field in the document JSON. The code must check the migration is complete using
::Elastic::DataMigrationService.migration_has_finished?
- Bump the
SCHEMA_VERSION
for the document JSON. The format is year and week number:YYYYWW
- Create a migration to backfill the field in the index. Use the
MigrationBackfillHelper
If the new field is an associated record
- Update specs for
Elastic::ProcessBookkeepingService
create associated records - Update N+1 specs for
preload_search_data
to create associated data records - Review Updating dependent associations in the index
Expose the field to the search service
- Add the filter to the
Search::Filter
concern. The concern is used in theSearch::GlobalService
,Search::GroupService
andSearch::ProjectService
. - Pass the field for the scope by updating the
scope_options
method. The method is defined inGitlab::Elastic::SearchResults
with overrides inGitlab::Elastic::GroupSearchResults
andGitlab::Elastic::ProjectSearchResults
. - Use the field in the query builder by adding an existing filter or creating a new one.
- Track the filter usage in searches in the
SearchController
Changing mapping of an existing field
- Update the field type in the index mapping to change it for newly created indices
- Bump the
SCHEMA_VERSION
for the document JSON. The format is year and week number:YYYYWW
- Create a migration to reindex all documents
using Zero downtime reindexing.
Use the
Search::Elastic::MigrationReindexTaskHelper
Changing field content
- Update the field content in the document JSON
- Bump the
SCHEMA_VERSION
for the document JSON. The format is year and week number:YYYYWW
- Create a migration to update documents. Use the
MigrationReindexBasedOnSchemaVersion
Cleaning up documents from an index
This may be used if documents are split from one index into separate indices or to remove data left in the index due to bugs.
- Bump the
SCHEMA_VERSION
for the document JSON. The format is year and week number:YYYYWW
- Create a migration to index all records. Use the
MigrationDatabaseBackfillHelper
- Create a migration to remove all documents with the previous
SCHEMA_VERSION
. Use theMigrationDeleteBasedOnSchemaVersion
Removing a field
The removal must be split across multiple milestones to support multi-version compatibility. To avoid dynamic mapping errors, the field must be removed from all documents before a Zero downtime reindexing.
Milestone M
:
- Remove the field from the index mapping to remove it from newly created indices
- Stop populating the field in the document JSON
- Bump the
SCHEMA_VERSION
for the document JSON. The format is year and week number:YYYYWW
- Remove any filters which use the field from the query builder
- Update the
scope_options
method to remove the field for the scope you are updating. The method is defined inGitlab::Elastic::SearchResults
with overrides inGitlab::Elastic::GroupSearchResults
andGitlab::Elastic::ProjectSearchResults
.
If the field is not used by other scopes:
- Remove the field from the
Search::Filter
concern. The concern is used in theSearch::GlobalService
,Search::GroupService
, andSearch::ProjectService
. - Remove filter tracking in searches in the
SearchController
Milestone M+1
:
- Create a migration to remove the field from all documents in the index. Use the
MigrationRemoveFieldsHelper
- Create a migration to reindex all documents with the field removed
using Zero downtime reindexing.
Use the
Search::Elastic::MigrationReindexTaskHelper
Updating authorization
In the QueryBuilder
framework, authorization is handled at the project level with the
by_search_level_and_membership
filter and at the group level
with the by_search_level_and_group_membership
filter.
In the legacy Proxy
framework, the authorization is handled inside the class.
Both frameworks use Search::GroupsFinder
and Search::ProjectsFinder
to query the groups and projects a user
has direct access to search. Search relies upon group and project visibility level and feature access level settings
for each scope. See roles and permissions documentation for more information.
Query builder framework
The query builder framework is used to build Elasticsearch queries. We also support a legacy query framework implemented
in the Elastic::Latest::ApplicationClassProxy
class and classes that inherit it.
New document types must use the query builder framework.
Creating a query
A query is built using:
- a query from
Search::Elastic::Queries
- one or more filters from
::Search::Elastic::Filters
- (optional) aggregations from
::Search::Elastic::Aggregations
- one or more formats from
::Search::Elastic::Formats
New scopes must create a new query builder class that inherits from Search::Elastic::QueryBuilder
.
The query builder framework provides a collection of pre-built filters to handle common search scenarios. These filters simplify the process of constructing complex query conditions without having to write raw Elasticsearch query DSL.
Creating a filter
Filters are essential components in building effective Elasticsearch queries. They help narrow down search results without affecting the relevance scoring.
-
All filters must be documented.
-
Filters are created as class level methods in
Search::Elastic::Filters
-
The method should start with
by_
. -
The method must take
query_hash
andoptions
parameters only. -
query_hash
is expected to contain a hash with this format.{ "query": { "bool": { "must": [], "must_not": [], "should": [], "filters": [], "minimum_should_match": null } } }
-
Use
add_filter
to add the filter to the query hash. Filters should add to thefilters
to avoid calculating score. The score calculation is done by the query itself. -
Use
context.name(:filters)
around the filter to add a name to the filter. This helps identify which part of a query and filter have allowed a result to be returned by the searchdef by_new_filter_type(query_hash:, options:) filter_selected_value = options[:field_value] context.name(:filters) do add_filter(query_hash, :query, :bool, :filter) do { term: { field_name: { _name: context.name(:field_name), value: filter_selected_value } } } end end end
Understanding Queries vs Filters
Queries in Elasticsearch serve two key purposes: filtering documents and calculating relevance scores. When building search functionality:
-
Queries are essential when relevance scoring is required to rank results by how well they match search criteria. They use the Boolean query's
must
,should
, andmust_not
clauses, all of which influence the document's final relevance score. -
Filters (within query context) determine whether documents appear in search results without affecting their score. For search operations where results only need to be included/excluded without ranking by relevance, using filters alone is more efficient and performs better at scale.
Choose the appropriate approach based on your search requirements - use queries with scoring clauses for ranked results, and rely on filters for simple inclusion/exclusion logic.
Filter Requirements and Usage
To use any filter:
- The index mapping must include all required fields specified in each filter's documentation
- Pass the appropriate parameters via the
options
hash when calling the filter - Each filter will generate the appropriate JSON structure and add it to your
query_hash
Filters can be composed together to create sophisticated search queries while maintaining readable and maintainable code.
Sending queries to Elasticsearch
The queries are sent to ::Gitlab::Search::Client
from Gitlab::Elastic::SearchResults
.
Results are parsed through a Search::Elastic::ResponseMapper
to translate
the response from Elasticsearch.
Model requirements
The model must respond to the to_ability_name
method so that the redaction logic can check if it has
Ability.allowed?(current_user, :"read_#{object.to_ability_name}", object)?
. The method must be added if
it does not exist.
The model must define a preload_search_data
scope to avoid N+1s.
Available Queries
All query builders must return a standardized query_hash
structure that conforms to Elasticsearch's Boolean query
syntax. The Search::Elastic::BoolExpr
class provides an interface for constructing Boolean queries.
The required query hash structure is:
{
"query": {
"bool": {
"must": [],
"must_not": [],
"should": [],
"filters": [],
"minimum_should_match": null
}
}
}
by_iid
Query by iid
field and document type. Requires type
and iid
fields.
{
"query": {
"bool": {
"filter": [
{
"term": {
"iid": {
"_name": "milestone:related:iid",
"value": 1
}
}
},
{
"term": {
"type": {
"_name": "doc:is_a:milestone",
"value": "milestone"
}
}
}
]
}
}
}
by_full_text
Performs a full text search. This query will use by_multi_match_query
or by_simple_query_string
if Advanced search syntax is used in the query string. by_multi_match_query
is behind the search_uses_match_queries
feature flag.
by_multi_match_query
Uses multi_match
Elasticsearch API. Can be customized with the following options:
-
count_only
- uses the Boolean query clausefilter
. Scoring and highlighting are not performed. -
query
- if no query is passed, usesmatch_all
Elasticsearch API -
keyword_match_clause
- if:should
is passed, uses the Boolean query clauseshould
. Default:must
clause
[2018-10-31T15:54:19,762][WARN ][o.e.c.r.a.DiskThresholdMonitor] [pval5Ct]
flood stage disk watermark [95%] exceeded on
[pval5Ct7SieH90t5MykM5w][pval5Ct][/usr/local/var/lib/elasticsearch/nodes/0] free: 56.2gb[3%],
all indices on this node will be marked read-only
```0
#### `by_simple_query_string`
Uses `simple_query_string` Elasticsearch API. Can be customized with the following options:
- `count_only` - uses the Boolean query clause `filter`. Scoring and highlighting are not performed.
- `query` - if no query is passed, uses `match_all` Elasticsearch API
- `keyword_match_clause` - if `:should` is passed, uses the Boolean query clause `should`. Default: `must` clause
```plaintext
[2018-10-31T15:54:19,762][WARN ][o.e.c.r.a.DiskThresholdMonitor] [pval5Ct]
flood stage disk watermark [95%] exceeded on
[pval5Ct7SieH90t5MykM5w][pval5Ct][/usr/local/var/lib/elasticsearch/nodes/0] free: 56.2gb[3%],
all indices on this node will be marked read-only
```1
#### `by_knn`
Requires options: `vectors_supported` (set to `:elasticsearch` or `:opensearch`) and `embedding_field`. Callers may optionally provide options: `embeddings`
Performs a hybrid search using embeddings. Uses `full_text_search` unless embeddings are supported.
Elasticsearch and OpenSearch DSL for `knn` queries is different. To support both, this query must be used with the `by_knn` filter.
The example below is for Elasticsearch.
```plaintext
[2018-10-31T15:54:19,762][WARN ][o.e.c.r.a.DiskThresholdMonitor] [pval5Ct]
flood stage disk watermark [95%] exceeded on
[pval5Ct7SieH90t5MykM5w][pval5Ct][/usr/local/var/lib/elasticsearch/nodes/0] free: 56.2gb[3%],
all indices on this node will be marked read-only
```2
### Available Filters
The following sections detail each available filter, its required fields, supported options, and example output.
#### `by_type`
Requires `type` field. Query with `doc_type` in options.
```plaintext
[2018-10-31T15:54:19,762][WARN ][o.e.c.r.a.DiskThresholdMonitor] [pval5Ct]
flood stage disk watermark [95%] exceeded on
[pval5Ct7SieH90t5MykM5w][pval5Ct][/usr/local/var/lib/elasticsearch/nodes/0] free: 56.2gb[3%],
all indices on this node will be marked read-only
```3
#### `by_group_level_confidentiality`
Requires `current_user` and `group_ids` fields. Query based on the permissions to user to read confidential group entities.
```plaintext
[2018-10-31T15:54:19,762][WARN ][o.e.c.r.a.DiskThresholdMonitor] [pval5Ct]
flood stage disk watermark [95%] exceeded on
[pval5Ct7SieH90t5MykM5w][pval5Ct][/usr/local/var/lib/elasticsearch/nodes/0] free: 56.2gb[3%],
all indices on this node will be marked read-only
```4
#### `by_project_confidentiality`
Requires `confidential`, `author_id`, `assignee_id`, `project_id` fields. Query with `confidential` in options.
```plaintext
[2018-10-31T15:54:19,762][WARN ][o.e.c.r.a.DiskThresholdMonitor] [pval5Ct]
flood stage disk watermark [95%] exceeded on
[pval5Ct7SieH90t5MykM5w][pval5Ct][/usr/local/var/lib/elasticsearch/nodes/0] free: 56.2gb[3%],
all indices on this node will be marked read-only
```5
#### `by_label_ids`
Requires `label_ids` field. Query with `label_names` in options.
```plaintext
[2018-10-31T15:54:19,762][WARN ][o.e.c.r.a.DiskThresholdMonitor] [pval5Ct]
flood stage disk watermark [95%] exceeded on
[pval5Ct7SieH90t5MykM5w][pval5Ct][/usr/local/var/lib/elasticsearch/nodes/0] free: 56.2gb[3%],
all indices on this node will be marked read-only
```6
#### `by_archived`
Requires `archived` field. Query with `search_level` and `include_archived` in options.
```plaintext
[2018-10-31T15:54:19,762][WARN ][o.e.c.r.a.DiskThresholdMonitor] [pval5Ct]
flood stage disk watermark [95%] exceeded on
[pval5Ct7SieH90t5MykM5w][pval5Ct][/usr/local/var/lib/elasticsearch/nodes/0] free: 56.2gb[3%],
all indices on this node will be marked read-only
```7
#### `by_state`
Requires `state` field. Supports values: `all`, `opened`, `closed`, and `merged`. Query with `state` in options.
```plaintext
[2018-10-31T15:54:19,762][WARN ][o.e.c.r.a.DiskThresholdMonitor] [pval5Ct]
flood stage disk watermark [95%] exceeded on
[pval5Ct7SieH90t5MykM5w][pval5Ct][/usr/local/var/lib/elasticsearch/nodes/0] free: 56.2gb[3%],
all indices on this node will be marked read-only
```8
#### `by_not_hidden`
Requires `hidden` field. Not applied for admins.
```plaintext
[2018-10-31T15:54:19,762][WARN ][o.e.c.r.a.DiskThresholdMonitor] [pval5Ct]
flood stage disk watermark [95%] exceeded on
[pval5Ct7SieH90t5MykM5w][pval5Ct][/usr/local/var/lib/elasticsearch/nodes/0] free: 56.2gb[3%],
all indices on this node will be marked read-only
```9
#### `by_work_item_type_ids`
Requires `work_item_type_id` field. Query with `work_item_type_ids` or `not_work_item_type_ids` in options.
```shell
curl "http://localhost:9200/gitlab-development/_settings?pretty"
```0
#### `by_author`
Requires `author_id` field. Query with `author_username` or `not_author_username` in options.
```shell
curl "http://localhost:9200/gitlab-development/_settings?pretty"
```1
#### `by_target_branch`
Requires `target_branch` field. Query with `target_branch` or `not_target_branch` in options.
```shell
curl "http://localhost:9200/gitlab-development/_settings?pretty"
```2
#### `by_source_branch`
Requires `source_branch` field. Query with `source_branch` or `not_source_branch` in options.
```shell
curl "http://localhost:9200/gitlab-development/_settings?pretty"
```3
#### `by_search_level_and_group_membership`
Requires `current_user`, `group_ids`, `traversal_id`, `search_level` fields. Query with `search_level` and
filter on `namespace_visibility_level` based on permissions user has for each group.
This filter can be used in place of `by_search_level_and_membership` if the data being searched does not contain the `project_id` field.
Examples are shown for an authenticated user. The JSON may be different for users with authorizations, admins, external, or anonymous users
##### global
```shell
curl "http://localhost:9200/gitlab-development/_settings?pretty"
```4
##### group
```shell
curl "http://localhost:9200/gitlab-development/_settings?pretty"
```5
#### `by_search_level_and_membership`
Requires `project_id`, `traversal_id` and project visibility (defaulting to `visibility_level` but can set with the `project_visibility_level_field` option) fields. Supports feature `*_access_level` fields. Query with `search_level`
and optionally `project_ids`, `group_ids`, `features`, and `current_user` in options.
Filtering is applied for:
- search level for global, group, or project
- membership for direct membership to groups and projects or shared membership through direct access to a group
- any feature access levels passed through `features`
Examples are shown for a logged in user. The JSON may be different for users with authorizations, admins, external, or anonymous users
##### global
```shell
curl "http://localhost:9200/gitlab-development/_settings?pretty"
```6
##### group
```shell
curl "http://localhost:9200/gitlab-development/_settings?pretty"
```7
##### project
```shell
curl "http://localhost:9200/gitlab-development/_settings?pretty"
```8
#### `by_knn`
Requires options: `vectors_supported` (set to `:elasticsearch` or `:opensearch`) and `embedding_field`. Callers may optionally provide options: `embeddings`
Elasticsearch and OpenSearch DSL for `knn` queries is different. To support both, this filter must be used with the
`by_knn` query.
#### `by_noteable_type`
Requires `noteable_type` field. Query with `noteable_type` in options. Sets `_source` to only return `noteable_id` field.
```shell
curl "http://localhost:9200/gitlab-development/_settings?pretty"
```9
## Testing scopes
Test any scope in the Rails console
```yaml
# turn off the disk allocator
cluster.routing.allocation.disk.threshold_enabled: false
```0
### Permissions tests
Search code has a final security check in `SearchService#redact_unauthorized_results`. This prevents
unauthorized results from being returned to users who don't have permission to view them. The check is
done in Ruby to handle inconsistencies in Elasticsearch permissions data due to bugs or indexing delays.
New scopes must add visibility specs to ensure proper access control.
To test that permissions are properly enforced, add tests using the [`'search respects visibility'` shared example](https://gitlab.com/gitlab-org/gitlab/-/blob/a489ad0fe4b4d1e392272736b020cf9bd43646da/ee/spec/support/shared_examples/services/search_service_shared_examples.rb)
in the EE specs:
- `ee/spec/services/search/global_service_spec.rb`
- `ee/spec/services/search/group_service_spec.rb`
- `ee/spec/services/search/project_service_spec.rb`
## Zero-downtime reindexing with multiple indices
This is not applicable yet as multiple indices functionality is not fully implemented.
Currently, GitLab can only handle a single version of setting. Any setting/schema changes would require reindexing everything from scratch. Since reindexing can take a long time, this can cause search functionality downtime.
To avoid downtime, GitLab is working to support multiple indices that
can function at the same time. Whenever the schema changes, the administrator
will be able to create a new index and reindex to it, while searches
continue to go to the older, stable index. Any data updates will be
forwarded to both indices. Once the new index is ready, an administrator can
mark it active, which will direct all searches to it, and remove the old
index.
This is also helpful for migrating to new servers, for example, moving to/from AWS.
Currently, we are on the process of migrating to this new design. Everything is hardwired to work with one single version for now.